All in one SSDT VS stripped SSDTs

[ammoune78]

Hey Master @MaLd0n How is it going, I hope you are very well and in good forms !

I just please, as you are a master, need to know a thing!

I have a fully working EFI, for my recently purchased "HP ENGAGE Flex Retail System" Mini Intel 10Th Gen PC. It have everything OOB, no peripheral changed, and everything is fine from booting to sleep and wake, running on Tahoe. Now when it comes to the ACPI, i have made a couple of SSDT suiting my hardware.

The thing that i didn't understand yet is, when i create an all in one SSDT with the exact same code, put it in ACPI folder, add it in the config. The boot process after DSMOS has arrived, hangs in AHCI things and stays there. When I cut all the code from the All-In-One-SSDT and copied back to a stripped SSDTs with no addition or omission, the boot process is back, and the sleep wake everything is back to normal.

What causes the booting failure, knowing that the aditional ACPI patches code never changed, except for devising it into SSDTs, each one of them, have it's own device or method calls.

 

 

ENGAGE SSDTs.zip

[MaLd0n]

You can simplify itammoune78.aml.zip

[ammoune78]

But without returning _ON and _OFF from GFX0=>iGPU into _PTS and _WAK, the PC won't turn on the display after wake from sleep!

[MaLd0n]

ammoune78.aml.zip

Check

[ammoune78]

20 minutes ago, MaLd0n said:

ammoune78.aml.zip

Check

No it doesn’t boot, stuck on Ahci things! Once i divide it into a group of SSDTs, it will work 

[MaLd0n]

You can try inject methods with Scope (\) (Into Definition Block)

Quote

External (_SB_.PCI0.GFX0._OFF, MethodObj)    // 0 Arguments
External (_SB_.PCI0.GFX0._ON_, MethodObj)    // 0 Arguments
External (OSDW, IntObj)

    Scope (\)
    {
        Method (\_PTS, 1, Serialized)  // _PTS: Prepare To Sleep
        {
            If (OSDW)
            {
                If (CondRefOf (\_SB.PCI0.GFX0._ON))
                {
                    \_SB.PCI0.GFX0._ON ()
                }

                _PTS (Arg0)
                If ((Arg0 == 0x03))
                {
                    Sleep (0x0100)
                }
            }
            Else
            {
                Return (Zero)
            }

            Return (Zero)
        }

        Method (\_WAK, 1, Serialized)  // _WAK: Wake
        {
            If (OSDW)
            {
                If (CondRefOf (\_SB.PCI0.GFX0._OFF))
                {
                    \_SB.PCI0.GFX0._OFF ()
                }

                If (((Arg0 < One) || (Arg0 > 0x05)))
                {
                    Return (_WAK (0x03))
                }
            }

            Return (_WAK (Arg0))
        }
    }

 

[ammoune78]

4 minutes ago, MaLd0n said:

You can try inject methods with Scope (\) (Into Definition Block)

 

This is what i'm doing in both SSDTs and the SSDT that have all of them. But i always cannot boot from the SSDT that contains all the patches! I do no why it suck with the SSDT alone, but i think that i'll stick with the SSDTs instead, because it's just a cosmetic thing that save from too much aml files in the ACPI folder and arrows in the config. But it's strange huh