Notebook: SMBUS patch question

[zoliky]

Hi,

Is there a way to check if SMBUS is working and patch has been applied correctly? Please tell me what's the difference between this patch:

 

Device (BUS0)
{
   Name (_CID, "smbus")  // _CID: Compatible ID
   Name (_ADR, Zero)  // _ADR: Address
   Device (DVL0)
   {
       Name (_ADR, 0x57)  // _ADR: Address
       Name (_CID, "diagsvault")  // _CID: Compatible ID
   }
}

 

and this one:

 

Device (BUS0)
{
   Name (_CID, "smbus")  // _CID: Compatible ID
   Name (_ADR, Zero)  // _ADR: Address
   Device (DVL0)
   {
       Name (_ADR, 0x57)  // _ADR: Address
       Name (_CID, "diagsvault")  // _CID: Compatible ID
       Method (_DSM, 4, NotSerialized)  // _DSM: Device-Specific Method
       {
           Store (Package (0x02)
               {
                   "address", 
                   0x57
               }, Local0)
           DTGP (Arg0, Arg1, Arg2, Arg3, RefOf (Local0))
           Return (Local0)
       }
   }
}

 

Is there any reason to include that additional Metdod _DSM and DTGP call? I ask this question because I saw these two different versions on the web.

I would be grateful for any suggestion. Thank you!

[pernacabeluda]

Hi,

I'm not sure, but if you look the ioreg dump of MacBooks, some do have the address property under SMBUS, and some don't. That property is in fact injected by the _DSM method in DSDT.

 

                        Method (_DSM, 4, NotSerialized)
                       {
                           Store (Package (0x08)
                               {
                                   "refnum", 
                                   0x00, 
                                   "address", 
                                   0x39, 
                                   "device-id", 
                                   0x0CD2, 
                                   "hdet", 
                                   0x01
                               }, Local0)
                           DTGP (Arg0, Arg1, Arg2, Arg3, RefOf (Local0))
                           Return (Local0)
                       }

http://tdev.me/2010/12/apple-hardware-dumps/