remove_entry not working

[toleda]

HD4000 framebuffer experiments. If Method (_DSM.... exist in GFX0 (parent_adr 0x00200000), DSDT Editor adds the new Method (_DSM.... after the existing entry resulting in a compile error: 8273 Error Name already exists in scope (_DSM)

Current patch

into method label _DSM parent_adr 0x00200000 remove_entry;
into device name_adr 0x00020000 insert
begin
   Method (_DSM, 4, NotSerialized)\n
   {\n
       Store (Package (0x02)\n
	     {\n
               "AAPL,ig-platform-id", \n
               Buffer (0x04) \n
               { \n
                  0x0A, 0x00, 0x66, 0x01 \n
               }, \n
           }, Local0)\n
       DTGP (Arg0, Arg1, Arg2, Arg3, RefOf (Local0))\n
       Return (Local0)\n
   }\n
end

Attached is dsdt with the compile error; first patch 0A, second patch 0B.

test.dsl.zip

[Cassio]

into method label _DSM parent_adr 0x00200000 remove_entry;

into device name_adr 0x00020000 insert

It's not 0x00200000, but 0x00020000.

[toleda]

It's not 0x00200000, but 0x00020000.

Pilot error, thanks.

Another problem: No success with a patch for these warnings:

11048 Warning Not all control paths return a value (_HID)

11048 Warning Reserved method must return a value (Integer/String required for _HID)

original dsdt

Method (_HID, 0, NotSerialized)
       {
           If (TCMF) {}
           Else
           {
               Return (0x0201D824)
           }
       }

patch code

into_all all code_regex (If\s\(TCMF)\s*\)
replace_matched
begin
   If (TCMF) \n
   { \n
       Return (Zero) \n
   } \n
end

after

// into_all all code_regex (If\s\(TCMF)\s*\) replace_matched 

       Method (_HID, 0, NotSerialized)
       {
               If (TCMF) 
    { 
        Return (Zero) 
    } 
{}
           Else
           {
               Return (0x0201D824)
           }
       }

Unfortunately, the {} remains preventing a successful compile. Manually removing the {} fixes compile. dsdt with problem attached. Thanks again for the incredible support.

test1.zip

[Cassio]

into_all all code_regex If\s\(TCMF\)\s\{\} replace_matched

 

Would you post your complete patches?

[toleda]

Would you post your complete patches?

The complete patch is in the "patch code" box (2nd code box above).