jamesst20

Sorry for the late reply. Here is the SendMe of my computer having trouble to sleep (Instant Wake): https://file.io/JEeW8rp8dupg and here is an EFI I found where the sleep works out of the box: https://github.com/Xmingbai/ASUS-TUF-GAMING-B660M-PLUS-Wi-Fi-D4-Hackintosh/releases/download/Ver0.8.3/ASUS-TUF-B660M-PLUS-.WIFI.-RX6950XTorRX6650XT-OC083-EFI.zip Not sure what I am doing wrong in mine. Edit: My bad I was missing the GPRW patch in ACPI. <dict> <key>Base</key> <string></string> <key>BaseSkip</key> <integer>0</integer> <key>Comment</key> <string>change Method(GPRW,2,N) to XPRW, pair with SSDT-GPRW.aml</string> <key>Count</key> <integer>0</integer> <key>Enabled</key> <true/> <key>Find</key> <data>R1BSVwI=</data> <key>Limit</key> <integer>0</integer> <key>Mask</key> <data></data> <key>OemTableId</key> <data></data> <key>Replace</key> <data>WFBSVwI=</data> <key>ReplaceMask</key> <data></data> <key>Skip</key> <integer>0</integer> <key>TableLength</key> <integer>0</integer> <key>TableSignature</key> <data></data> </dict> Do you see any improvement that can be done while we're here

Hi, I have an ASUS-TUF-GAMING-B660M-PLUS-Wi-Fi-D4 and I am unable to get sleep to not instant wake. I have tested someone else EFI and my sleep works with it https://github.com/Xmingbai/ASUS-TUF-GAMING-B660M-PLUS-Wi-Fi-D4-Hackintosh I noticed that EFI uses SSDT-DISABLE-AWAC instead of SSDT-AWAC and I would like to understand what that means, what's the difference and if it could be related to my sleep issue? Thank you

Won't it break USB Wake ?

How can I inject new?

The question is : How to write a patch that remove/delete/disable _PRW from device XDCI without rewriting complete DSDT.aml Tried this and doesn't work: DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000) { External (_SB_.PCI0.XDCI, DeviceObj) External (GPRW, MethodObj) // 2 Arguments Scope (_SB.PCI0.XDCI) { Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, Zero)) } } } Edit: Now this is about your DSDT.aml you made me. I edited it and added in XHC Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, 0x03)) } and I noticed 3 things: 1. Built in PS/2 touchpad is not working 2. Instant wake if my USB mouse is connected 3. Built in USB Keyboard doesn't wake the computer.

Don't worry I know, the question is not about that

Sorry for the confusion, I am not trying to add those methods to XCI to bring back wake capability by USB. I'm trying to learn how SSDT patches work and are made. Let's make a scenario where one device is waking up the laptop and I would like to remove wake capability. In that example I would like to remove _PRW and _DSW seen there: I wrote this SSDT patch and added it to OpenCore folder: DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000) { External (_SB_.PCI0.XDCI, DeviceObj) External (GPRW, MethodObj) // 2 Arguments Scope (_SB.PCI0.XDCI) { Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, Zero)) } } } This patch don't appear to replace/overwrite the method shown in the screenshot. It actually seems to have no effect. Would you mind explaining me what is wrong with my patch?

That's very nice ! Thanks I had never heard of this fork before. I'm wondering why the "EnableForAll" doesn't exist in the official build. It makes too much sense to not be present. Windows/Linux don't require any acpi patch. No doubt some people are having troubles. Edit: Question For learning purposes: Let's say my original DSDT has the following How would I write a patch that makes sure it can't wake the computer? I gave a try for fun and wrote this DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000) { External (_SB_.PCI0.XDCI, DeviceObj) External (GPRW, MethodObj) // 2 Arguments Scope (_SB.PCI0.XDCI) { Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, Zero)) } } } It sadly doesn't appear to have done anything ? What did I do wrong?

Thanks for the detailed response It's very appreciated and indeed impressive. I would like to report that my sleep issue appears to be resolved. Not a single sleep issue since I added TSC_sync_margin=0. According to the ACPI documentation, _DSW is optional just like you said. I'm a developer but far from familiar with the ACPI syntax/language. Still wondering though, since you have so many people like me requesting optimized DSDT, did you make yourself some script or it's manual work by hand every time ? I will edit the DSDT you made me later and add _PRW in XHC and report back

Still testing, so far no freeze. About the USB Wake Support, you said I needed to add to your DSDT Method (_PRW, ....) in XHC Opening my original DSDT in MaciASL (dumped with SSDTTime in Windows), I can see that Method (_PRW, ...) is present several times and in the custom DSDT you made me it's totally gone. I'm trying to understand: does it mean every device listing the _PRW method has the capabilities to wake my computer which could lead to unwanted/random wake? If so, is that why you removed it everywhere in the first place? Also, the custom DSDT you made me is much leaner that my original, how did you clean it up? Are you using some kind of tool or script or it's done by hand? Thanks again MaLd0n!

Sad news, I've got one freeze What would be the next step? TSC_sync_margin=0 ?

Almost 24 hours with no freeze. It seems promising. Would you be able to make a DSDT that supports USB Wake Support?

Just installed the kext. I also removed DebugEnhancer because it hasn't proven itself of any use for us. I will let you know if the freeze ever happen again. I still can't wake my laptop with mouse and keyboard since I use DSDT.aml. Should I revert back to my SSDTs and ACPI renames?

Also, I just got a sleep wake failure I don't know if it helps but every time a freeze happens, when I come in the room, the "Alien" logo on the lid is already powered on like it tried to wake up on its own. It never freezes when I wake the computer by myself. Also I have DebugEnhancer, can I get log about the errors?

Yes. Laptop built in keyboard is also USB but I have a USB keyboard connected too that I use

Thanks MaLd0n for getting back. I went ahead, removed my ACPI renames and all of my SSDTs and put your DSDT.aml. It's like the last time. The laptop can sleep, but I can't wake it unless I open the lid and press the power button With SSDTs, the laptop can wake with my mouse and keyboard.

I meant: Do I keep RebaseRegions enabled and do I put back my ACPI renames (for Fix HPET and Fix IRQ) along with your DSDT You made me enable RebaseRegion and disable ACPI renames to dump DSDT. I want to know if I revert those back

Still waiting for your input

Do I keep RebaseRegions enabled and do I put back my ACPI renames (for Fix HPET and Fix IRQ) I'm still using my new SSDTs and I have yet been able to reproduce the sleep issue. It's unusual normally it doesn't make it through the night. Only difference with new SSDTs vs old ones is the BIOS update and that I am using SSDT-USB-EC from SSDTTime and SSDT-USBX from Dortania instead of the SSDT-EC-USBX from Dortania

Went back to using my SSDTs (new ones with new BIOS), Upgraded to OpenCore 0.7.8 and Upgraded Kexts. Selected Rebase Regions and disabled HPET rename patch and rebooted. USB Wake Support is re-working again https://www.sendspace.com/file/31fs0n

Removed all SSDT, added your DSDT.aml, added DebugEnhancer with boot flag, removed OC patches (IRQ/HPET) and rebooted. Did sudo pmset -a hibernatemode 0 and put the laptop in sleep. Laptop sleep just fine but I can't wake it up unless I open the lid and press power button Seems waking by USB is no longer working. Send me https://www.sendspace.com/file/877pyy Edit: Updated BIOS from 1.3.1 to 1.7.0 I redumped DSDT using SSDTTime in Windows (I booted without OpenCore). Could you re-do me a new DSDT? (I attached the zip) It did not fix usb wake SSDTTime - Alienware - 1.7.0 BIOS.zip

@MaLd0n Still need confirmation

Thanks for getting back to me. Can you confirm the following? 1. Install DebugEnhancer and add -dbgenhdbg boot flag. (I'm guessing I should use one with latest fix at the bottom here for monterey? https://github.com/acidanthera/bugtracker/issues/1916) 2. Remove all .aml files and use only your DSDT.aml 3. Should I keep IRQ Patches in config.plist? 4. What do you mean by disabling hibernate? Last step: Reproduce sleep wake failure. How will I get the log?

Thank you Can you explain me how to disable hibernate and what are the advantage/disadvantage? Also, if I use your DSDT, should I remove all my other aml files? Do i need to keep my IRQ patches in config.plist? What are the improvements inside your DSDT over what I currently have ? I did this from the OpenCore guide few weeks ago: sudo pmset autopoweroff 0 sudo pmset powernap 0 sudo pmset standby 0 sudo pmset proximitywake 0 sudo pmset tcpkeepalive 0

Send me : https://www.sendspace.com/file/4btvd4 Hi, Sleep is working properly however it randomly freeze while in sleep. Sometimes I come and move my mouse and the laptop power up just fine from sleep and sometimes it seems like it powered on already on its own but it's frozen there. I can here fan but the screen remains black. Other times it powered on on it's own already but the screen is still black and moving my mouse power it up fine too. Is there a way to fix this? I don't know if it helps, but sometimes when I force reboot my laptop, there is some kind of BIOS Recovery / Failsafe on whitescreen that is displayed telling me I did not shutdown properly multiple times. Logs are not very helpful but here it is from Console App Sleep Wake Failure_2022-02-09-133020_Jamess-MacBook-Pro.diag Sleep Wake failure in EFI Failure code:: 0x00000000 0x0000001f Please IGNORE the below stackshot ================================================================ Date/Time: 2022-02-09 13:30:17.119 -0500 OS Version: ??? ??? (Build ???) Architecture: x86_64 Report Version: 35 Incident Identifier: 27C75AD4-CC49-4606-A5F9-434E1DD3A94C Data Source: Stackshots Shared Cache: 40432A03-88D3-305F-9C0C-E7549E71D927 slid base address 0x7ff812b1b000, slide 0x12b1b000 Event: Sleep Wake Failure Duration: 0.00s Steps: 1 Boot args: keepsyms=1 swd_panic=1 debug=0x100 alcid=11 -wegnoegpu -igfxblr igfxonln=1 chunklist-security-epoch=0 -chunklist-no-rev2-dev Time Awake Since Boot: 16s Process: swd [360] Architecture: x86_64 Footprint: 408 KB Time Since Fork: 1s Num samples: 1 (1) Thread 0x93d 1 sample (1) priority 4 (base 4) <thread QoS background (requested background), thread darwinbg, process darwinbg, IO tier 2> 1 ??? [0x1077ad4fe] 1 1 ??? [0x107098454] 1 1 ??? [0x1070981e8] 1 1 __stack_snapshot_with_config + 10 (libsystem_kernel.dylib + 149174) [0x7ff812e1c6b6] 1 *1 ??? [0xffffff8000228226] 1 *1 ??? [0xffffff800099e9d4] 1 *1 ??? [0xffffff8000894e84] 1 *1 ??? [0xffffff800024be78] 1 *1 ??? [0xffffff80002881ad] (running) 1 Binary Images: 0x7ff812df8000 - 0x7ff812e2efff libsystem_kernel.dylib (8019.61.5) <5AA1E5BE-B5B8-3A02-9885-A8C99E0CA378> /usr/lib/system/libsystem_kernel.dylib