[Guide] - Brightness Hotkey Remapping

[wardoge]

10 hours ago, MaLd0n said:

what ur hardware? processor?

i7-7700HQ with Intel 630 HD Graphics

GTX 1060 6GB (Disabled of course)

16GB DDR4

120GB NVMe m.2 SSD

1TB HDD

Killer Ethernet

Intel WiFi (Not Working) -> TP-Link WN725N V3 EU

Synaptics Touchpad

Built-in Steelseries keyboard

Catalina 1.15.5

 

Sometimes when tapped once it just continuously increasing or decreasing the brightness non-stop and then hangs the system

Edited August 5, 2020 by wardoge

[MaLd0n]

let me check ur efi folder

[wardoge]

On 8/5/2020 at 12:31 PM, MaLd0n said:

let me check ur efi folder

Here u go

 

https://drive.google.com/file/d/1G4UhacgPpa7o_taS4XFKmeHHuKlOJZEC/view?usp=sharing

[MaLd0n]

13 hours ago, wardoge said:

Here u go

DSDT.aml.zip

remove ssdts

[wardoge]

On 8/7/2020 at 5:43 AM, MaLd0n said:

DSDT.aml.zip 35.19 kB · 1 download

remove ssdts

Thanks again for the time you took for helping me, but after I've tried the DSDT and deleting all ssts, the problem still persist, and suddenly the sound doesn't work

[MaLd0n]

4 hours ago, wardoge said:

Thanks again for the time you took for helping me, but after I've tried the DSDT and deleting all ssts, the problem still persist, and suddenly the sound doesn't work

if dont work, try with ssdt from whatevergreen project

[An Nhật]

On 5/5/2020 at 12:15 AM, MaLd0n said:

into method label BRT6 replace_content
begin
    If (LEqual (Arg0, One))\n
    {\n
// Brightness Up\n
        Notify (^^LPCB.PS2K, 0x0406)\n
    }\n
    If (And (Arg0, 0x02))\n
    {\n
// Brightness Down\n
        Notify (^^LPCB.PS2K, 0x0405)\n
    }\n
end;

into device label PS2K insert
begin
Method (_DSM, 4, NotSerialized)  // _DSM: Device-Specific Method\n
    {\n
        If (!Arg2)\n
        {\n
            Return (Buffer ()\n
            {\n
                 0x03\n
            })\n
        }\n
        Return (Package ()\n
        {\n
            "RM,oem-id", \n
            "DELL", \n
            "RM,oem-table-id", \n
            "WN09"\n
        })\n
    }\n
end

 

I tried this patch but it doesn't work. fn + F11 and fn + F12 still don't work

Edited August 10, 2020 by An Nhật

[Deihmos]

On 6/30/2019 at 9:03 AM, onemanosx said:

 

The process of figuring out the hotkeys are similar with RH acpidebug method. In order to implement into SSDT, one just need to translate the code into SSDT implementation and not forgetting renaming device to "NULL" (in clover).

 

Recently, I just did a "make-over" patch for my laptop running OpenCore. And the output is just as such in the screenshot.

 

Here, you can see the patched code in SSDT, original code in DSDT and the renaming of hotkey button in OC's config.plist

 

https://imgur.com/C8x9yGG

How do you figure out what to rename the hotkey button? I am trying to implement this on my HP laptop using SSDT hot patch. 

[V3-571G]

Hello. I have used the guide to help me patch my brightness function keys. I have completed a working patch for EC values Q11 and Q12 that corresponds with the Fn+F8 and Fn+F9 brightness hotkeys on my laptop. Everything is working perfectly.

Here is the patch I used on my DSDT.aml in MaciASL:

into method label _Q11 replace_content
begin
// Brightness Down\n
Notify(\_SB.PCI0.LPCB.PS2K, 0x0205)\n
Notify(\_SB.PCI0.LPCB.PS2K, 0x0285)\n
end;
into method label _Q12 replace_content
begin
// Brightness Up\n
Notify(\_SB.PCI0.LPCB.PS2K, 0x0206)\n
Notify(\_SB.PCI0.LPCB.PS2K, 0x0286)\n
end;

And now here is what it looks like when I search the patched DSDT.aml for the Q11 and Q12 values:

Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
{
 Notify (PS2K, 0x0205)
 Notify (PS2K, 0x0285)
}

Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
{
 Notify (PS2K, 0x0206)
 Notify (PS2K, 0x0286)
}

My question is, would it be possible to convert this into an SSDT that eliminates the need to have the patched DSDT.aml?

Thanks for any help I might receive.

[MaLd0n]

4 hours ago, V3-571G said:

My question is, would it be possible to convert this into an SSDT that eliminates the need to have the patched DSDT.aml?

rename q11 and q12 via acpi renames and inject new with ssdt

[V3-571G]

On 10/4/2020 at 3:15 PM, MaLd0n said:

rename q11 and q12 via acpi renames and inject new with ssdt

Thanks for the reply! The good news is that I think I have part of the ACPI renames set up now. This is what it looks like in my config.plist under ACPI > Patch:

<dict>
	<key>Comment</key>
	<string>Rename __46 to _Q11</string>
	<key>Count</key>
	<integer>0</integer>
	<key>Enabled</key>
	<false/>
	<key>Find</key>
	<data>X180Ng==</data>
	<key>Limit</key>
	<integer>0</integer>
	<key>Replace</key>
	<data>X1ExMQ==</data>
</dict>
<dict>
	<key>Comment</key>
	<string>Rename e045 to _Q12</string>
	<key>Count</key>
	<integer>0</integer>
	<key>Enabled</key>
	<false/>
	<key>Find</key>
	<data>ZTA0NQ==</data>
	<key>Limit</key>
	<integer>0</integer>
	<key>Replace</key>
	<data>X1ExMg==</data>
</dict>

As mentioned, the codes I retrieved from ACPIDebug for the Fn+F8 and Fn+F9 hotkeys - These are Q11 and Q12

The Scroll Lock and Pause hotkeys are NOT EC controlled... Therefore I have to use Rehabman's debug VoodooPS2Controller to obtain these codes. For these keys I get PS2 codes 46 and e045. I have adjusted 46 to __46 to make it 4 characters, I think that is correct.

But the thing about making the SSDT, I am extremely confused about this, how would I go about it? I'm still a beginner who has mainly relied on guides up until this point, so any guidance specific to my scenario would be welcome. (I assume that I will need to do something with the second piece of code that I provided in my other post)

[MaLd0n]

rename _Q11 to _Qxx abd inject ssdt with new method

[AmazingHarsh]

I am getting two error 

19811, 6114, Result is not used, operator has no effect

11558, 6126, syntax error, unexpected PARSEOP_ARG1

after pasting and saving dsdt and having error

I have just generated it by f4 ?

[MaLd0n]

5 hours ago, AmazingHarsh said:

I am getting two error 

post here. ill check these errors

[AmazingHarsh]

Here is my dsdt , screenshot of error in zip file

dsdt+errors.zip

 

[MaLd0n]

7 minutes ago, AmazingHarsh said:

Here is my dsdt , screenshot of error in zip file

DSDT.aml.zip

[AmazingHarsh]

u have pasted that step 1 code in that DSDT ?

[AmazingHarsh]

I am not getting  api debug in console also  the command - log show | grep -I acpidebug  is not showing anything. I have placed rehabman kext in clover manually and edited the DSDT 

[MaLd0n]

u dont need debug

dsdt above have this patch

[AmazingHarsh]

it means I only do step 3 ?

 

Edited October 12, 2020 by AmazingHarsh
misspelled

[MaLd0n]

just paste dsdt in clover/acpi/patched folder

[AmazingHarsh]

I did but no brightness control from keyboard ?

[MaLd0n]

3 minutes ago, AmazingHarsh said:

I did but no brightness control from keyboard ?

Post one Full Dump
https://www.olarila.com/topic/10301-olarila-runme-dumper/
https://olarila.com/files/Utils/RunMe.app.zip

[AmazingHarsh]

here it is 
https://drive.google.com/file/d/14A5Tq84AFrB4oUW5EHUi8Hq7RjHTA0sO/view?usp=sharing

[MaLd0n]

4 minutes ago, AmazingHarsh said:

here it is 

use dsdt

DSDT.aml.zip