DSDT editor and patcher

[zoliky]

I'm wondering what method/command the DSDT editor use to extract the DSDT. It gives me a lot of errors and warnings.

As an alternative, I tried to obtain my DSDT through ioreg/terminal:

 

sudo perl -e 'open(CMD, "ioreg -lw0 \| grep DSDT|") or die; while(<CMD>) { chomp; if($_ =~ /\"DSDT\.?\d?\"=<([^>]*)>/) { $buff = $1; open(PIP, "|xxd -r -p > ~/Desktop/dsdt.aml") or die; print PIP "$1"; } }'

 

The terminal command gives me a cleaner DSDT (the same DSDT as Ubuntu gives me) with 0 warning and just 1 error:

 

Error 4095 -    ^ syntax error, unexpected PARSEOP_NAMESEG, expecting PARSEOP_DEFINITIONBLOCK

 

Can someone clarify this to me?

I can do the DSDT editing in TextMate. I don't necessary need DSDT Editor.

Thank you!

[Cassio]

DSDT Editor extracts DSDT exactly the same way as the command you posted, from ioreg.

You can use any text editor and iasl command line tool to compile/decompile, you don't need to use DSDT Editor.

Once you fix the "one error" of your "cleaner DSDT" you will get all the same errors and warnings (unless you use older version of iasl, which doesn't show as many warnings and errors as the newer versions).

[zoliky]

Yes, sorry. You're perfectly right.

I built the latest iasl from sources (20121114) and I have 200 errors.

I have this code in my DSDT (HP 4540s laptop, i5, intel hd3000):

 

If (CondRefOf (FPED))
{
 FPED ()
}

 

I commented out the code:

 

// If (CondRefOf (FPED))
// {
//  FPED ()
//}

 

All 200 errors fixed. I'm wondering what does this FPED thing do.

[Cassio]

It's not FPED that causes the errors, but the IF. There can't be IF/ELSE directly inside a device, it must be inside a method. This syntax error causes all other errors.

The correct fix would be moving that code block into method _INI, which is called when the device is started.

[zoliky]

Thank you Cassio. I greatly appreciate your help.

Can you please take a look at my DSDT ?

I'm not sure where should I move that IF condition, because I have more method INI. Thank you so much!

hp4340s.dsl.zip

[Cassio]

The one inside the same scope (GFX0), line 3935.

[zoliky]

Thank you so much! Should I insert the original code like this? :

Method (_INI, 0, NotSerialized)  // _INI: Initialize
{
   Store (0x01, INIM)
   DKET ()
   Store (\_SB.SBRC (), Local0)
   Or (Local0, 0x80000000, \_SB.PCI0.GFX0.BCLP)
   Store (0x00, WDSA)
   Store (0x00, WDST)
   Store (0x00, WDGN)
	If (CondRefOf (FPED))
   {
      FPED ()
   }
}

 

or just call the function directly without the conditional?

 

Method (_INI, 0, NotSerialized)  // _INI: Initialize
{
   Store (0x01, INIM)
   DKET ()
   Store (\_SB.SBRC (), Local0)
   Or (Local0, 0x80000000, \_SB.PCI0.GFX0.BCLP)
   Store (0x00, WDSA)
   Store (0x00, WDST)
   Store (0x00, WDGN)
   FPED ()    // <---- calling the function (IF REMOVED)
}

[Cassio]

Just move the original code.

[hackerz]

Hello guys...

 

Need some help on making my bcm943224hmb working...

It's a wifi + bluetooth module...

For now, I'm using the DSDT.aml compiled by Maldon for scorpioserve

My card has Vendor ID : 14e4 Product ID : 4353 subsys vendor ID : 103c subsys product id : 1510...

I think the card has been succesfully identified as in my ioreg -l output :

ioreg.rar

but there is no wifi icon appears... When I tried to run assist me from Network, it says that my wifi is turned off and needs to be turned on... When I clicked at turn on, there is no wifi available listed... At least at my home, there is ONE that should be available...

 

So for now, I'm trying to inject Airport Extreme subsys vendor ID and product ID into the DSDT by using the information provided and did like this :

into device name_adr 0x001C0000 insert
begin
Device (WLAN)\n
{\n
   Name (_ADR, 0x00)\n
   Method (_DSM, 4, NotSerialized)\n
   {\n
       Store (Package ()\n
           {\n
               "AAPL,slot-name", \n
               Buffer (0x08)\n
               {\n
                   "AirPort"\n
               }, \n
               "device_type", \n
               Buffer (0x08)\n
               {\n
                   "AirPort"\n
               }, \n
               "model", \n
               Buffer (0x29)\n
               {\n
                   "Broadcom 802.11 a/b/g/n Wireless Adapter"\n
               }, \n
               "subsystem-id", \n
               Buffer (0x04)\n
               {\n
                   0xE9, 0x00, 0x00, 0x00\n
               }, \n
               "subsystem-vendor-id", \n
               Buffer (0x04)\n
               {\n
                   0x6B, 0x10, 0x00, 0x00\n
               }\n
           }, Local0)\n
       DTGP (Arg0, Arg1, Arg2, Arg3, RefOf (Local0))\n
       Return (Local0)\n
   }\n
}
end

 

and the result is just the same as before...

Do I need to put extra method or something like _PRW? Or changing the code? Any helps? Ehehehe 

[zoliky]

Just move the original code.

Thank you!

[sainn]

Hey Guys;

Im new on the hacintosh. So can anyone tell me how can i make my own dsdt file?

My laptop is toshiba Satellite Pro C850-128 ?

I look at the compatibilty with Kexts.Jar. It's showing me working, expect wireless. It doesnt matter wireless.

I want to start with install. Can someone help me for make dsdt files?

[Cassio]

You don't need a patched DSDT to install OS X.

You may need it after installing to get some things working or to fix issues.

[sainn]

But when i try to install, it's giving me error,

"No DSDT found"

[Cassio]

This is not an error, it's a normal message.

Open a new topic, post a picture of the screen and a description of your installation method.

[yb255]

I downloaded the Windows/linux but I don't know what to run nothing is working. I don't find any tutorial for the windows version. Help!!

[Cassio]

Run DSDT Editor.bat (you must have JRE installed).

[yb255]

I just installed JRE but when I run DSDT Editor.bat I get a little black window which close immediately. 

[Cassio]

If you have JRE installed you should be able to run it by opening DSDTParser.jar

[yb255]

Yes thanks Cassio in fact DSDTParser.jar was opening with WinRar...

[Tribes11]

I've downloaded the DSDT Editor, extracted DSDT and when I've clicked on COMPILE (without editing anything yet) it already is giving me errors lol, how can I fix that?

I can't even save the DSDT.aml to work on edits cause it won't save..