Alienware m17 R4 - Randomly not waking up

[jamesst20]

23 hours ago, MaLd0n said:

u just need add _prw into device xhci

 

Sad news, I've got one freeze  What would be the next step? TSC_sync_margin=0  ?

[MaLd0n]

u need test it bro

[jamesst20]

On 2/23/2022 at 7:27 AM, MaLd0n said:

u need test it bro

Still testing, so far no freeze.

 

About the USB Wake Support, you said I needed to add to your DSDT Method (_PRW, ....)  in XHC

Opening my original DSDT in MaciASL (dumped with SSDTTime in Windows), I can see that Method (_PRW, ...) is present several times and in the custom DSDT you made me it's totally gone. 

 

I'm trying to understand: does it mean every device listing the _PRW method has the capabilities to wake my computer which could lead to unwanted/random wake? If so, is that why you removed it everywhere in the first place?

 

Also, the custom DSDT you made me is much leaner that my original, how did you clean it up? Are you using some kind of tool or script or it's done by hand?

 

Thanks again MaLd0n!

[MaLd0n]

9 minutes ago, jamesst20 said:

I can see that Method (_PRW, ...) is present several times and in the custom DSDT you made me it's totally gone

u need add only _prw from XHC device

9 minutes ago, jamesst20 said:

I'm trying to understand: does it mean every device listing the _PRW method has the capabilities to wake my computer which could lead to unwanted/random wake? If so, is that why you removed it everywhere in the first place?

_PRW: Power Resources for Wake and _DSW: Device Sleep Wake

10 minutes ago, jamesst20 said:

Also, the custom DSDT you made me is much leaner that my original, how did you clean it up? Are you using some kind of tool or script or it's done by hand?

i have all chipsets in my brain ?

The way start here with us with dsdt editor and patcher and dsdt auto-patcher since 2006

Maciasl with my preferences, compiler, etc

https://olarila.com/files/Utils/MaciASL.app.zip

[jamesst20]

On 2/24/2022 at 8:36 AM, MaLd0n said:

u need add only _prw from XHC device

_PRW: Power Resources for Wake and _DSW: Device Sleep Wake

i have all chipsets in my brain ?

The way start here with us with dsdt editor and patcher and dsdt auto-patcher since 2006

Maciasl with my preferences, compiler, etc

https://olarila.com/files/Utils/MaciASL.app.zip

Thanks for the detailed response It's very appreciated and indeed impressive.

I would like to report that my sleep issue appears to be resolved. Not a single sleep issue since I added TSC_sync_margin=0.

 

According to the ACPI documentation, _DSW is optional just like you said. I'm a developer but far from familiar with the ACPI syntax/language. 

 

Still wondering though, since you have so many people like me requesting optimized DSDT, did you make yourself some script or it's manual work by hand every time ?

 

I will edit the DSDT you made me later and add _PRW in XHC and report back

[MaLd0n]

2 hours ago, jamesst20 said:

I will edit the DSDT you made me later and add _PRW in XHC and report back

check here. very nice work from these guys

https://www.olarila.com/topic/24542-opencore_no_acpi-opencore-with-additional-featureschanges-implemented/

 

[jamesst20]

On 2/26/2022 at 4:48 PM, MaLd0n said:

check here. very nice work from these guys

https://www.olarila.com/topic/24542-opencore_no_acpi-opencore-with-additional-featureschanges-implemented/

 

That's very nice ! Thanks I had never heard of this fork before. I'm wondering why the "EnableForAll" doesn't exist in the official build. It makes too much sense to not be present. Windows/Linux don't require any acpi patch. No doubt some people are having troubles.

 

Edit: Question

For learning purposes: 

Let's say my original DSDT has the following

 

How would I write a patch that makes sure it can't wake the computer? I gave a try for fun and wrote this

DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000)
{
    External (_SB_.PCI0.XDCI, DeviceObj)
    External (GPRW, MethodObj)    // 2 Arguments

    Scope (_SB.PCI0.XDCI)
    {
        Method (_PRW, 0, NotSerialized)  // _PRW: Power Resources for Wake
        {
            Return (GPRW (0x6D, Zero))
        }
    }
}

It sadly doesn't appear to have done anything ? 

What did I do wrong?

Edited March 2, 2022 by jamesst20

[MaLd0n]

Xhci device

[jamesst20]

7 hours ago, MaLd0n said:

Xhci device

Sorry for the confusion, I am not trying to add those methods to XCI to bring back wake capability by USB.

I'm trying to learn how SSDT patches work and are made.

 

Let's make a scenario where one device is waking up the laptop and I would like to remove wake capability. In that example I would like to remove _PRW and _DSW seen there:

 

I wrote this SSDT patch and added it to OpenCore folder:

DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000)
{
    External (_SB_.PCI0.XDCI, DeviceObj)
    External (GPRW, MethodObj)    // 2 Arguments

    Scope (_SB.PCI0.XDCI)
    {
        Method (_PRW, 0, NotSerialized)  // _PRW: Power Resources for Wake
        {
            Return (GPRW (0x6D, Zero))
        }
    }
}

This patch don't appear to replace/overwrite the method shown in the screenshot. It actually seems to have no effect.

Would you mind explaining me what is wrong with my patch? 

Edited March 2, 2022 by jamesst20

[MaLd0n]

device to wake from usb is xhci not xdci

[jamesst20]

23 hours ago, MaLd0n said:

device to wake from usb is xhci not xdci

Don't worry I know, the question is not about that

[MaLd0n]

2 hours ago, jamesst20 said:

Don't worry I know, the question is not about that

im use _prw for example only into xhci and lan device(wake from lan) only it

[jamesst20]

6 hours ago, MaLd0n said:

im use _prw for example only into xhci and lan device(wake from lan) only it

The question is : How to write a patch that remove/delete/disable _PRW from device XDCI without rewriting complete DSDT.aml

 

Tried this and doesn't work: 

DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000)
{
    External (_SB_.PCI0.XDCI, DeviceObj)
    External (GPRW, MethodObj)    // 2 Arguments

    Scope (_SB.PCI0.XDCI)
    {
        Method (_PRW, 0, NotSerialized)  // _PRW: Power Resources for Wake
        {
            Return (GPRW (0x6D, Zero))
        }
    }
}

 

Edit:

Now this is about your DSDT.aml you made me. I edited it and added in XHC

            Method (_PRW, 0, NotSerialized)  // _PRW: Power Resources for Wake
            {
                Return (GPRW (0x6D, 0x03))
            }

and I noticed 3 things:

1. Built in PS/2 touchpad is not working

2. Instant wake if my USB mouse is connected

3. Built in USB Keyboard doesn't wake the computer.

Edited March 3, 2022 by jamesst20

[MaLd0n]

u need rename _PRW to XPRW for example and inject new

[jamesst20]

On 3/3/2022 at 6:17 PM, MaLd0n said:

u need rename _PRW to XPRW for example and inject new

How can I inject new?

[MaLd0n]

inject ur acpitable , dsdt or ssdt

[jamesst20]

9 hours ago, MaLd0n said:

inject ur acpitable , dsdt or ssdt

Won't it break USB Wake ?

[MaLd0n]

u need test after edits