jamesst20

Sorry for the late reply. Here is the SendMe of my computer having trouble to sleep (Instant Wake): https://file.io/JEeW8rp8dupg and here is an EFI I found where the sleep works out of the box: https://github.com/Xmingbai/ASUS-TUF-GAMING-B660M-PLUS-Wi-Fi-D4-Hackintosh/releases/download/Ver0.8.3/ASUS-TUF-B660M-PLUS-.WIFI.-RX6950XTorRX6650XT-OC083-EFI.zip Not sure what I am doing wrong in mine. Edit: My bad I was missing the GPRW patch in ACPI. <dict> <key>Base</key> <string></string> <key>BaseSkip</key> <integer>0</integer> <key>Comment</key> <string>change Method(GPRW,2,N) to XPRW, pair with SSDT-GPRW.aml</string> <key>Count</key> <integer>0</integer> <key>Enabled</key> <true/> <key>Find</key> <data>R1BSVwI=</data> <key>Limit</key> <integer>0</integer> <key>Mask</key> <data></data> <key>OemTableId</key> <data></data> <key>Replace</key> <data>WFBSVwI=</data> <key>ReplaceMask</key> <data></data> <key>Skip</key> <integer>0</integer> <key>TableLength</key> <integer>0</integer> <key>TableSignature</key> <data></data> </dict> Do you see any improvement that can be done while we're here

Hi, I have an ASUS-TUF-GAMING-B660M-PLUS-Wi-Fi-D4 and I am unable to get sleep to not instant wake. I have tested someone else EFI and my sleep works with it https://github.com/Xmingbai/ASUS-TUF-GAMING-B660M-PLUS-Wi-Fi-D4-Hackintosh I noticed that EFI uses SSDT-DISABLE-AWAC instead of SSDT-AWAC and I would like to understand what that means, what's the difference and if it could be related to my sleep issue? Thank you

Won't it break USB Wake ?

How can I inject new?

The question is : How to write a patch that remove/delete/disable _PRW from device XDCI without rewriting complete DSDT.aml Tried this and doesn't work: DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000) { External (_SB_.PCI0.XDCI, DeviceObj) External (GPRW, MethodObj) // 2 Arguments Scope (_SB.PCI0.XDCI) { Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, Zero)) } } } Edit: Now this is about your DSDT.aml you made me. I edited it and added in XHC Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, 0x03)) } and I noticed 3 things: 1. Built in PS/2 touchpad is not working 2. Instant wake if my USB mouse is connected 3. Built in USB Keyboard doesn't wake the computer.

Don't worry I know, the question is not about that

Sorry for the confusion, I am not trying to add those methods to XCI to bring back wake capability by USB. I'm trying to learn how SSDT patches work and are made. Let's make a scenario where one device is waking up the laptop and I would like to remove wake capability. In that example I would like to remove _PRW and _DSW seen there: I wrote this SSDT patch and added it to OpenCore folder: DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000) { External (_SB_.PCI0.XDCI, DeviceObj) External (GPRW, MethodObj) // 2 Arguments Scope (_SB.PCI0.XDCI) { Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, Zero)) } } } This patch don't appear to replace/overwrite the method shown in the screenshot. It actually seems to have no effect. Would you mind explaining me what is wrong with my patch?

That's very nice ! Thanks I had never heard of this fork before. I'm wondering why the "EnableForAll" doesn't exist in the official build. It makes too much sense to not be present. Windows/Linux don't require any acpi patch. No doubt some people are having troubles. Edit: Question For learning purposes: Let's say my original DSDT has the following How would I write a patch that makes sure it can't wake the computer? I gave a try for fun and wrote this DefinitionBlock ("", "SSDT", 2, "hack", "_XDCI", 0x00000000) { External (_SB_.PCI0.XDCI, DeviceObj) External (GPRW, MethodObj) // 2 Arguments Scope (_SB.PCI0.XDCI) { Method (_PRW, 0, NotSerialized) // _PRW: Power Resources for Wake { Return (GPRW (0x6D, Zero)) } } } It sadly doesn't appear to have done anything ? What did I do wrong?

Thanks for the detailed response It's very appreciated and indeed impressive. I would like to report that my sleep issue appears to be resolved. Not a single sleep issue since I added TSC_sync_margin=0. According to the ACPI documentation, _DSW is optional just like you said. I'm a developer but far from familiar with the ACPI syntax/language. Still wondering though, since you have so many people like me requesting optimized DSDT, did you make yourself some script or it's manual work by hand every time ? I will edit the DSDT you made me later and add _PRW in XHC and report back

Still testing, so far no freeze. About the USB Wake Support, you said I needed to add to your DSDT Method (_PRW, ....) in XHC Opening my original DSDT in MaciASL (dumped with SSDTTime in Windows), I can see that Method (_PRW, ...) is present several times and in the custom DSDT you made me it's totally gone. I'm trying to understand: does it mean every device listing the _PRW method has the capabilities to wake my computer which could lead to unwanted/random wake? If so, is that why you removed it everywhere in the first place? Also, the custom DSDT you made me is much leaner that my original, how did you clean it up? Are you using some kind of tool or script or it's done by hand? Thanks again MaLd0n!

Sad news, I've got one freeze What would be the next step? TSC_sync_margin=0 ?

Almost 24 hours with no freeze. It seems promising. Would you be able to make a DSDT that supports USB Wake Support?

Just installed the kext. I also removed DebugEnhancer because it hasn't proven itself of any use for us. I will let you know if the freeze ever happen again. I still can't wake my laptop with mouse and keyboard since I use DSDT.aml. Should I revert back to my SSDTs and ACPI renames?

Also, I just got a sleep wake failure I don't know if it helps but every time a freeze happens, when I come in the room, the "Alien" logo on the lid is already powered on like it tried to wake up on its own. It never freezes when I wake the computer by myself. Also I have DebugEnhancer, can I get log about the errors?

Yes. Laptop built in keyboard is also USB but I have a USB keyboard connected too that I use